discuss@lists.openscad.org

OpenSCAD general discussion Mailing-list

View all threads

example of fillets

JW
Jim Witte
Mon, Feb 7, 2022 7:58 PM

cryptic 2 and 3 letter names makes it hard

to even guess what's going on.

Not to mention when you come back the in a year or two and wonder "what
the heck was I think?  And what exactly does that function do? :)

On Sat, Jan 22, 2022 at 11:24 AM Adrian Mariano avm4@cornell.edu wrote:

The fillets looks nice.  How does your code work and what can it
actually do?  What are its limitations?  It looks like there is a
sphere-sphere routine and a cylinder-cylinder routine?  You might
consider a more readable and documented coding style for your
libraries if you are going to give your code to others.  Having all
your top level functions be cryptic 2 and 3 letter names makes it hard
to even guess what's going on.

The fillet connecting the U-shaped beam to the sphere is missing a row.

Also, I think the tons of warnings are slowing your code down quite a
bit.  It would be a significant improvement if the code didn't
generate warnings.  I strongly encourage you to do the following:  Go
to Preferences->Advanced and select "Stop on first warning", near the
bottom of the list.  This turns warnings into fatal errors and will
force you to fix the warnings.  It also makes it easier to fix them
since you don't get 200 warnings any more, just the first one.

On Sat, Jan 22, 2022 at 10:54 AM Sanjeev Prabhakar
sprabhakar2006@gmail.com wrote:

I have written a few functions which create fillets between 2

intersecting solids.

It is showing a lot of warnings but it still works and renders
need confirmation in case this works on other systems as well.
I have macbook air M1 and 20220.1.21 version of OpenSCAD


OpenSCAD mailing list
To unsubscribe send an email to discuss-leave@lists.openscad.org


OpenSCAD mailing list
To unsubscribe send an email to discuss-leave@lists.openscad.org

> cryptic 2 and 3 letter names makes it hard to even guess what's going on. Not to mention when *you* come back the in a year or two and wonder "what the heck was I think? And what exactly does that function do? :) On Sat, Jan 22, 2022 at 11:24 AM Adrian Mariano <avm4@cornell.edu> wrote: > The fillets looks nice. How does your code work and what can it > actually do? What are its limitations? It looks like there is a > sphere-sphere routine and a cylinder-cylinder routine? You might > consider a more readable and documented coding style for your > libraries if you are going to give your code to others. Having all > your top level functions be cryptic 2 and 3 letter names makes it hard > to even guess what's going on. > > The fillet connecting the U-shaped beam to the sphere is missing a row. > > Also, I think the tons of warnings are slowing your code down quite a > bit. It would be a significant improvement if the code didn't > generate warnings. I strongly encourage you to do the following: Go > to Preferences->Advanced and select "Stop on first warning", near the > bottom of the list. This turns warnings into fatal errors and will > force you to fix the warnings. It also makes it easier to fix them > since you don't get 200 warnings any more, just the first one. > > On Sat, Jan 22, 2022 at 10:54 AM Sanjeev Prabhakar > <sprabhakar2006@gmail.com> wrote: > > > > I have written a few functions which create fillets between 2 > intersecting solids. > > It is showing a lot of warnings but it still works and renders > > need confirmation in case this works on other systems as well. > > I have macbook air M1 and 20220.1.21 version of OpenSCAD > > > > > > _______________________________________________ > > OpenSCAD mailing list > > To unsubscribe send an email to discuss-leave@lists.openscad.org > _______________________________________________ > OpenSCAD mailing list > To unsubscribe send an email to discuss-leave@lists.openscad.org >
SP
Sanjeev Prabhakar
Tue, Feb 8, 2022 1:48 AM

I will write the functions clearly.
Actually initially these were written considering only I myself will use
them.
Now with so many functions,  even I myself get confused sometimes

On Tue, 8 Feb 2022, 01:29 Jim Witte, jim.witte@gmail.com wrote:

cryptic 2 and 3 letter names makes it hard

to even guess what's going on.

Not to mention when you come back the in a year or two and wonder "what
the heck was I think?  And what exactly does that function do? :)

On Sat, Jan 22, 2022 at 11:24 AM Adrian Mariano avm4@cornell.edu wrote:

The fillets looks nice.  How does your code work and what can it
actually do?  What are its limitations?  It looks like there is a
sphere-sphere routine and a cylinder-cylinder routine?  You might
consider a more readable and documented coding style for your
libraries if you are going to give your code to others.  Having all
your top level functions be cryptic 2 and 3 letter names makes it hard
to even guess what's going on.

The fillet connecting the U-shaped beam to the sphere is missing a row.

Also, I think the tons of warnings are slowing your code down quite a
bit.  It would be a significant improvement if the code didn't
generate warnings.  I strongly encourage you to do the following:  Go
to Preferences->Advanced and select "Stop on first warning", near the
bottom of the list.  This turns warnings into fatal errors and will
force you to fix the warnings.  It also makes it easier to fix them
since you don't get 200 warnings any more, just the first one.

On Sat, Jan 22, 2022 at 10:54 AM Sanjeev Prabhakar
sprabhakar2006@gmail.com wrote:

I have written a few functions which create fillets between 2

intersecting solids.

It is showing a lot of warnings but it still works and renders
need confirmation in case this works on other systems as well.
I have macbook air M1 and 20220.1.21 version of OpenSCAD


OpenSCAD mailing list
To unsubscribe send an email to discuss-leave@lists.openscad.org


OpenSCAD mailing list
To unsubscribe send an email to discuss-leave@lists.openscad.org


OpenSCAD mailing list
To unsubscribe send an email to discuss-leave@lists.openscad.org

I will write the functions clearly. Actually initially these were written considering only I myself will use them. Now with so many functions, even I myself get confused sometimes On Tue, 8 Feb 2022, 01:29 Jim Witte, <jim.witte@gmail.com> wrote: > > cryptic 2 and 3 letter names makes it hard > to even guess what's going on. > > Not to mention when *you* come back the in a year or two and wonder "what > the heck was I think? And what exactly does that function do? :) > > On Sat, Jan 22, 2022 at 11:24 AM Adrian Mariano <avm4@cornell.edu> wrote: > >> The fillets looks nice. How does your code work and what can it >> actually do? What are its limitations? It looks like there is a >> sphere-sphere routine and a cylinder-cylinder routine? You might >> consider a more readable and documented coding style for your >> libraries if you are going to give your code to others. Having all >> your top level functions be cryptic 2 and 3 letter names makes it hard >> to even guess what's going on. >> >> The fillet connecting the U-shaped beam to the sphere is missing a row. >> >> Also, I think the tons of warnings are slowing your code down quite a >> bit. It would be a significant improvement if the code didn't >> generate warnings. I strongly encourage you to do the following: Go >> to Preferences->Advanced and select "Stop on first warning", near the >> bottom of the list. This turns warnings into fatal errors and will >> force you to fix the warnings. It also makes it easier to fix them >> since you don't get 200 warnings any more, just the first one. >> >> On Sat, Jan 22, 2022 at 10:54 AM Sanjeev Prabhakar >> <sprabhakar2006@gmail.com> wrote: >> > >> > I have written a few functions which create fillets between 2 >> intersecting solids. >> > It is showing a lot of warnings but it still works and renders >> > need confirmation in case this works on other systems as well. >> > I have macbook air M1 and 20220.1.21 version of OpenSCAD >> > >> > >> > _______________________________________________ >> > OpenSCAD mailing list >> > To unsubscribe send an email to discuss-leave@lists.openscad.org >> _______________________________________________ >> OpenSCAD mailing list >> To unsubscribe send an email to discuss-leave@lists.openscad.org >> > _______________________________________________ > OpenSCAD mailing list > To unsubscribe send an email to discuss-leave@lists.openscad.org >