discuss@lists.openscad.org

OpenSCAD general discussion Mailing-list

View all threads

Extrude function - refreshed PR

MW
Mark Watson
Sat, Jan 18, 2025 10:33 PM

Hi,

I've been using OpenSCAD for a couple of years. Many thanks to all
developers. I really enjoy the declarative software style vs the point and
click of other cad software. Though since I am a professional software
developer myself, I might be biased to this approach!

A few weeks ago I found out about a feature I really like and feel is not
currently well catered for in the core. nrdvana made a PR for a great
generic 'extrude' back in 2019. It adds a new built-in module that extrudes
between a series of child 2D polygons (with matching number of vertices).
https://github.com/openscad/openscad/pull/2796
I guess this could almost be possible with an openscad module, I think the
main blocker is that the polygon vertices are not exposed to the language
so it would have to be built as a set of lists?

Anyway after I found it, I was excited by it and thought it'd be amazing
to have as a built-in. I then realised that it had not progressed in
several years and was now quite out of sync with main. So I took it and
manually rebased it on top of main and put a new PR in here:
https://github.com/openscad/openscad/pull/5584

After a little discussion on IRC someone kindly suggested adding some unit
tests would be a good idea. So I've gone ahead and added some of the .scad
file ones (emulating linear extrude, rotate extrude, the original examples
and some edge cases).

So... in order to get this merged what needs doing? Would someone more
experienced with the codebase be able to give it a quick review please? I'm
happy to spend a little time on this to tidy up, add extra features etc.

Best regards,

Mark Watson

Hi, I've been using OpenSCAD for a couple of years. Many thanks to all developers. I really enjoy the declarative software style vs the point and click of other cad software. Though since I am a professional software developer myself, I might be biased to this approach! A few weeks ago I found out about a feature I really like and feel is not currently well catered for in the core. nrdvana made a PR for a great generic 'extrude' back in 2019. It adds a new built-in module that extrudes between a series of child 2D polygons (with matching number of vertices). https://github.com/openscad/openscad/pull/2796 I guess this could almost be possible with an openscad module, I think the main blocker is that the polygon vertices are not exposed to the language so it would have to be built as a set of lists? Anyway after I found it, I was excited by it and thought it'd be amazing to have as a built-in. I then realised that it had not progressed in several years and was now quite out of sync with main. So I took it and manually rebased it on top of main and put a new PR in here: https://github.com/openscad/openscad/pull/5584 After a little discussion on IRC someone kindly suggested adding some unit tests would be a good idea. So I've gone ahead and added some of the .scad file ones (emulating linear extrude, rotate extrude, the original examples and some edge cases). So... in order to get this merged what needs doing? Would someone more experienced with the codebase be able to give it a quick review please? I'm happy to spend a little time on this to tidy up, add extra features etc. Best regards, Mark Watson