All the test that import AMF fail for me on Windows. Is this supposed to be working or is there an open issue for it?

On Aug 30, 2018, at 8:42 AM, nop head <nop.head@gmail.com> wrote: > > All the test that import AMF fail for me on Windows. > > Is this supposed to be working or is there an open issue for it? To my knowledge it’s supposed to work, but it’s not a very widely used feature, so I’m not sure where/when this last worked. If you have any more context about how it fails, that may be revealing. -Marius

It does nothing silently. Under MSYS2 I think it is a build problem because qmake cant find libzip but I tested it with the Windows snapshot and that doesn't work either. I will look into it. So does nobody use AMF and Windows? Package libzip was not found in the pkg-config search path. Perhaps you should add the directory containing `libzip.pc' to the PKG_CONFIG_PATH environment variable On 30 August 2018 at 14:21, Marius Kintel <marius@kintel.net> wrote: > On Aug 30, 2018, at 8:42 AM, nop head <nop.head@gmail.com> wrote: > > > > All the test that import AMF fail for me on Windows. > > > > Is this supposed to be working or is there an open issue for it? > > To my knowledge it’s supposed to work, but it’s not a very widely used > feature, so I’m not sure where/when this last worked. > If you have any more context about how it fails, that may be revealing. > > -Marius > > > _______________________________________________ > OpenSCAD mailing list > Discuss@lists.openscad.org > http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >

It's entirely possible that we're ignoring a build error for the snapshot as well; we don't have an automated test pipeline set up for Windows as we do on the other platforms. I'd wager that virtually nobody uses AMF at all - that standard doesn't seem to be going anywhere : / -Marius On Thu, Aug 30, 2018 at 10:22 AM, nop head <nop.head@gmail.com> wrote: > It does nothing silently. Under MSYS2 I think it is a build problem > because qmake cant find libzip but I tested it with the Windows snapshot > and that doesn't work either. > I will look into it. > > So does nobody use AMF and Windows? > > Package libzip was not found in the pkg-config search path. > Perhaps you should add the directory containing `libzip.pc' > to the PKG_CONFIG_PATH environment variable > > > On 30 August 2018 at 14:21, Marius Kintel <marius@kintel.net> wrote: > >> On Aug 30, 2018, at 8:42 AM, nop head <nop.head@gmail.com> wrote: >> > >> > All the test that import AMF fail for me on Windows. >> > >> > Is this supposed to be working or is there an open issue for it? >> >> To my knowledge it’s supposed to work, but it’s not a very widely used >> feature, so I’m not sure where/when this last worked. >> If you have any more context about how it fails, that may be revealing. >> >> -Marius >> >> >> _______________________________________________ >> OpenSCAD mailing list >> Discuss@lists.openscad.org >> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >> > > > _______________________________________________ > OpenSCAD mailing list > Discuss@lists.openscad.org > http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org > >

Cura removed AMF support in 2016, at the same time that they added 3MF support. Various reasons were given for removing AMF support: * nobody uses it * the standard contradicts itself * it is not an open standard (ie, devs need to pay money for a copy of the standard, no sharing) On 30 August 2018 at 10:31, Marius Kintel <marius@kintel.net> wrote: > It's entirely possible that we're ignoring a build error for the snapshot > as well; we don't have an automated test pipeline set up for Windows as we > do on the other platforms. > > I'd wager that virtually nobody uses AMF at all - that standard doesn't > seem to be going anywhere : / > > -Marius > > On Thu, Aug 30, 2018 at 10:22 AM, nop head <nop.head@gmail.com> wrote: > >> It does nothing silently. Under MSYS2 I think it is a build problem >> because qmake cant find libzip but I tested it with the Windows snapshot >> and that doesn't work either. >> I will look into it. >> >> So does nobody use AMF and Windows? >> >> Package libzip was not found in the pkg-config search path. >> Perhaps you should add the directory containing `libzip.pc' >> to the PKG_CONFIG_PATH environment variable >> >> >> On 30 August 2018 at 14:21, Marius Kintel <marius@kintel.net> wrote: >> >>> On Aug 30, 2018, at 8:42 AM, nop head <nop.head@gmail.com> wrote: >>> > >>> > All the test that import AMF fail for me on Windows. >>> > >>> > Is this supposed to be working or is there an open issue for it? >>> >>> To my knowledge it’s supposed to work, but it’s not a very widely used >>> feature, so I’m not sure where/when this last worked. >>> If you have any more context about how it fails, that may be revealing. >>> >>> -Marius >>> >>> >>> _______________________________________________ >>> OpenSCAD mailing list >>> Discuss@lists.openscad.org >>> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >>> >> >> >> _______________________________________________ >> OpenSCAD mailing list >> Discuss@lists.openscad.org >> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >> >> > > _______________________________________________ > OpenSCAD mailing list > Discuss@lists.openscad.org > http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org > >

The test suit seems to use it as a means to an end, rather than just testing AMF. $ ctest -R cube running 'C:/msys64/home/ChrisP/openscad/tests/../Release/openscad.exe --info' to generate sysinfo.txt Post test:C:/msys64/mingw64/bin/python.exe "C:/msys64/home/ChrisP/openscad/tests/test_pretty_print.py" --builddir=C:/msys64/home/ChrisP/openscad/tests Test project C:/msys64/home/ChrisP/openscad/tests Enforcing Default test configuration. Use ctest -C <config> to override Start 132: dumptest_cube-tests 1/14 Test #132: dumptest_cube-tests ................. Passed 0.29 sec Start 209: dumptest-examples_text_on_cube 2/14 Test #209: dumptest-examples_text_on_cube ...... Passed 0.28 sec Start 303: cgalpngtest_cube-tests 3/14 Test #303: cgalpngtest_cube-tests .............. Passed 1.00 sec Start 339: cgalpngtest_cube-with-hole 4/14 Test #339: cgalpngtest_cube-with-hole ..........***Failed 0.65 sec Start 466: opencsgtest_cube-tests 5/14 Test #466: opencsgtest_cube-tests .............. Passed 0.64 sec Start 516: opencsgtest_cube-with-hole 6/14 Test #516: opencsgtest_cube-with-hole ..........***Failed 0.70 sec Start 643: csgpngtest_cube-tests 7/14 Test #643: csgpngtest_cube-tests ............... Passed 1.04 sec Start 680: csgpngtest_cube-with-hole 8/14 Test #680: csgpngtest_cube-with-hole ...........***Failed 0.94 sec Start 807: throwntogethertest_cube-tests 9/14 Test #807: throwntogethertest_cube-tests ....... Passed 0.69 sec Start 855: throwntogethertest_cube-with-hole 10/14 Test #855: throwntogethertest_cube-with-hole ...***Failed 0.64 sec Start 918: monotonepngtest_cube10 11/14 Test #918: monotonepngtest_cube10 .............. Passed 0.65 sec Start 919: stlpngtest_cube10 12/14 Test #919: stlpngtest_cube10 ................... Passed 0.96 sec Start 920: offpngtest_cube10 13/14 Test #920: offpngtest_cube10 ................... Passed 0.93 sec Start 921: amfpngtest_cube10 14/14 Test #921: amfpngtest_cube10 ...................***Failed 0.94 sec 64% tests passed, 5 tests failed out of 14 Total Test time (real) = 10.56 sec The following tests FAILED: 339 - cgalpngtest_cube-with-hole (Failed) 516 - opencsgtest_cube-with-hole (Failed) 680 - csgpngtest_cube-with-hole (Failed) 855 - throwntogethertest_cube-with-hole (Failed) 921 - amfpngtest_cube10 (Failed) report saved: On 30 August 2018 at 16:17, doug moen <doug@moens.org> wrote: > Cura removed AMF support in 2016, at the same time that they added 3MF > support. > Various reasons were given for removing AMF support: > * nobody uses it > * the standard contradicts itself > * it is not an open standard (ie, devs need to pay money for a copy of the > standard, no sharing) > > > On 30 August 2018 at 10:31, Marius Kintel <marius@kintel.net> wrote: > >> It's entirely possible that we're ignoring a build error for the snapshot >> as well; we don't have an automated test pipeline set up for Windows as we >> do on the other platforms. >> >> I'd wager that virtually nobody uses AMF at all - that standard doesn't >> seem to be going anywhere : / >> >> -Marius >> >> On Thu, Aug 30, 2018 at 10:22 AM, nop head <nop.head@gmail.com> wrote: >> >>> It does nothing silently. Under MSYS2 I think it is a build problem >>> because qmake cant find libzip but I tested it with the Windows snapshot >>> and that doesn't work either. >>> I will look into it. >>> >>> So does nobody use AMF and Windows? >>> >>> Package libzip was not found in the pkg-config search path. >>> Perhaps you should add the directory containing `libzip.pc' >>> to the PKG_CONFIG_PATH environment variable >>> >>> >>> On 30 August 2018 at 14:21, Marius Kintel <marius@kintel.net> wrote: >>> >>>> On Aug 30, 2018, at 8:42 AM, nop head <nop.head@gmail.com> wrote: >>>> > >>>> > All the test that import AMF fail for me on Windows. >>>> > >>>> > Is this supposed to be working or is there an open issue for it? >>>> >>>> To my knowledge it’s supposed to work, but it’s not a very widely used >>>> feature, so I’m not sure where/when this last worked. >>>> If you have any more context about how it fails, that may be revealing. >>>> >>>> -Marius >>>> >>>> >>>> _______________________________________________ >>>> OpenSCAD mailing list >>>> Discuss@lists.openscad.org >>>> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >>>> >>> >>> >>> _______________________________________________ >>> OpenSCAD mailing list >>> Discuss@lists.openscad.org >>> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >>> >>> >> >> _______________________________________________ >> OpenSCAD mailing list >> Discuss@lists.openscad.org >> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >> >> > > _______________________________________________ > OpenSCAD mailing list > Discuss@lists.openscad.org > http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org > >

Without libzip the AMF importer falls back to only being able to read non zipped AMF files. cube-with-hole.amf is XML, so it should be able to read it without libzip. More investigation required. On 30 August 2018 at 17:31, nop head <nop.head@gmail.com> wrote: > The test suit seems to use it as a means to an end, rather than just > testing AMF. > > $ ctest -R cube > running 'C:/msys64/home/ChrisP/openscad/tests/../Release/openscad.exe > --info' to generate sysinfo.txt > Post test:C:/msys64/mingw64/bin/python.exe "C:/msys64/home/ChrisP/ > openscad/tests/test_pretty_print.py" --builddir=C:/msys64/home/ > ChrisP/openscad/tests > Test project C:/msys64/home/ChrisP/openscad/tests > Enforcing Default test configuration. Use ctest -C <config> to override > Start 132: dumptest_cube-tests > 1/14 Test #132: dumptest_cube-tests ................. Passed 0.29 sec > Start 209: dumptest-examples_text_on_cube > 2/14 Test #209: dumptest-examples_text_on_cube ...... Passed 0.28 sec > Start 303: cgalpngtest_cube-tests > 3/14 Test #303: cgalpngtest_cube-tests .............. Passed 1.00 sec > Start 339: cgalpngtest_cube-with-hole > 4/14 Test #339: cgalpngtest_cube-with-hole ..........***Failed 0.65 sec > Start 466: opencsgtest_cube-tests > 5/14 Test #466: opencsgtest_cube-tests .............. Passed 0.64 sec > Start 516: opencsgtest_cube-with-hole > 6/14 Test #516: opencsgtest_cube-with-hole ..........***Failed 0.70 sec > Start 643: csgpngtest_cube-tests > 7/14 Test #643: csgpngtest_cube-tests ............... Passed 1.04 sec > Start 680: csgpngtest_cube-with-hole > 8/14 Test #680: csgpngtest_cube-with-hole ...........***Failed 0.94 sec > Start 807: throwntogethertest_cube-tests > 9/14 Test #807: throwntogethertest_cube-tests ....... Passed 0.69 sec > Start 855: throwntogethertest_cube-with-hole > 10/14 Test #855: throwntogethertest_cube-with-hole ...***Failed 0.64 > sec > Start 918: monotonepngtest_cube10 > 11/14 Test #918: monotonepngtest_cube10 .............. Passed 0.65 sec > Start 919: stlpngtest_cube10 > 12/14 Test #919: stlpngtest_cube10 ................... Passed 0.96 sec > Start 920: offpngtest_cube10 > 13/14 Test #920: offpngtest_cube10 ................... Passed 0.93 sec > Start 921: amfpngtest_cube10 > 14/14 Test #921: amfpngtest_cube10 ...................***Failed 0.94 > sec > > 64% tests passed, 5 tests failed out of 14 > > Total Test time (real) = 10.56 sec > > The following tests FAILED: > 339 - cgalpngtest_cube-with-hole (Failed) > 516 - opencsgtest_cube-with-hole (Failed) > 680 - csgpngtest_cube-with-hole (Failed) > 855 - throwntogethertest_cube-with-hole (Failed) > 921 - amfpngtest_cube10 (Failed) > report saved: > > > On 30 August 2018 at 16:17, doug moen <doug@moens.org> wrote: > >> Cura removed AMF support in 2016, at the same time that they added 3MF >> support. >> Various reasons were given for removing AMF support: >> * nobody uses it >> * the standard contradicts itself >> * it is not an open standard (ie, devs need to pay money for a copy of >> the standard, no sharing) >> >> >> On 30 August 2018 at 10:31, Marius Kintel <marius@kintel.net> wrote: >> >>> It's entirely possible that we're ignoring a build error for the >>> snapshot as well; we don't have an automated test pipeline set up for >>> Windows as we do on the other platforms. >>> >>> I'd wager that virtually nobody uses AMF at all - that standard doesn't >>> seem to be going anywhere : / >>> >>> -Marius >>> >>> On Thu, Aug 30, 2018 at 10:22 AM, nop head <nop.head@gmail.com> wrote: >>> >>>> It does nothing silently. Under MSYS2 I think it is a build problem >>>> because qmake cant find libzip but I tested it with the Windows snapshot >>>> and that doesn't work either. >>>> I will look into it. >>>> >>>> So does nobody use AMF and Windows? >>>> >>>> Package libzip was not found in the pkg-config search path. >>>> Perhaps you should add the directory containing `libzip.pc' >>>> to the PKG_CONFIG_PATH environment variable >>>> >>>> >>>> On 30 August 2018 at 14:21, Marius Kintel <marius@kintel.net> wrote: >>>> >>>>> On Aug 30, 2018, at 8:42 AM, nop head <nop.head@gmail.com> wrote: >>>>> > >>>>> > All the test that import AMF fail for me on Windows. >>>>> > >>>>> > Is this supposed to be working or is there an open issue for it? >>>>> >>>>> To my knowledge it’s supposed to work, but it’s not a very widely used >>>>> feature, so I’m not sure where/when this last worked. >>>>> If you have any more context about how it fails, that may be revealing. >>>>> >>>>> -Marius >>>>> >>>>> >>>>> _______________________________________________ >>>>> OpenSCAD mailing list >>>>> Discuss@lists.openscad.org >>>>> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >>>>> >>>> >>>> >>>> _______________________________________________ >>>> OpenSCAD mailing list >>>> Discuss@lists.openscad.org >>>> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >>>> >>>> >>> >>> _______________________________________________ >>> OpenSCAD mailing list >>> Discuss@lists.openscad.org >>> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >>> >>> >> >> _______________________________________________ >> OpenSCAD mailing list >> Discuss@lists.openscad.org >> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >> >> >

The reason it does not work on Windows is the AMF parser uses fs::path to represent element hierarchies in the XML file, for example /amf/object/mesh/volume/triangle. On Windows fs:path uses \ instead of / so the paths don't match those in the maps of functions. So no functions are called and and empty polyset is returned. On 30 August 2018 at 17:50, nop head <nop.head@gmail.com> wrote: > Without libzip the AMF importer falls back to only being able to read non > zipped AMF files. > cube-with-hole.amf is XML, so it should be able to read it without libzip. > More investigation required. > > On 30 August 2018 at 17:31, nop head <nop.head@gmail.com> wrote: > >> The test suit seems to use it as a means to an end, rather than just >> testing AMF. >> >> $ ctest -R cube >> running 'C:/msys64/home/ChrisP/openscad/tests/../Release/openscad.exe >> --info' to generate sysinfo.txt >> Post test:C:/msys64/mingw64/bin/python.exe "C:/msys64/home/ChrisP/openscad/tests/test_pretty_print.py" >> --builddir=C:/msys64/home/ChrisP/openscad/tests >> Test project C:/msys64/home/ChrisP/openscad/tests >> Enforcing Default test configuration. Use ctest -C <config> to override >> Start 132: dumptest_cube-tests >> 1/14 Test #132: dumptest_cube-tests ................. Passed 0.29 >> sec >> Start 209: dumptest-examples_text_on_cube >> 2/14 Test #209: dumptest-examples_text_on_cube ...... Passed 0.28 >> sec >> Start 303: cgalpngtest_cube-tests >> 3/14 Test #303: cgalpngtest_cube-tests .............. Passed 1.00 >> sec >> Start 339: cgalpngtest_cube-with-hole >> 4/14 Test #339: cgalpngtest_cube-with-hole ..........***Failed 0.65 >> sec >> Start 466: opencsgtest_cube-tests >> 5/14 Test #466: opencsgtest_cube-tests .............. Passed 0.64 >> sec >> Start 516: opencsgtest_cube-with-hole >> 6/14 Test #516: opencsgtest_cube-with-hole ..........***Failed 0.70 >> sec >> Start 643: csgpngtest_cube-tests >> 7/14 Test #643: csgpngtest_cube-tests ............... Passed 1.04 >> sec >> Start 680: csgpngtest_cube-with-hole >> 8/14 Test #680: csgpngtest_cube-with-hole ...........***Failed 0.94 >> sec >> Start 807: throwntogethertest_cube-tests >> 9/14 Test #807: throwntogethertest_cube-tests ....... Passed 0.69 >> sec >> Start 855: throwntogethertest_cube-with-hole >> 10/14 Test #855: throwntogethertest_cube-with-hole ...***Failed 0.64 >> sec >> Start 918: monotonepngtest_cube10 >> 11/14 Test #918: monotonepngtest_cube10 .............. Passed 0.65 >> sec >> Start 919: stlpngtest_cube10 >> 12/14 Test #919: stlpngtest_cube10 ................... Passed 0.96 >> sec >> Start 920: offpngtest_cube10 >> 13/14 Test #920: offpngtest_cube10 ................... Passed 0.93 >> sec >> Start 921: amfpngtest_cube10 >> 14/14 Test #921: amfpngtest_cube10 ...................***Failed 0.94 >> sec >> >> 64% tests passed, 5 tests failed out of 14 >> >> Total Test time (real) = 10.56 sec >> >> The following tests FAILED: >> 339 - cgalpngtest_cube-with-hole (Failed) >> 516 - opencsgtest_cube-with-hole (Failed) >> 680 - csgpngtest_cube-with-hole (Failed) >> 855 - throwntogethertest_cube-with-hole (Failed) >> 921 - amfpngtest_cube10 (Failed) >> report saved: >> >> >> On 30 August 2018 at 16:17, doug moen <doug@moens.org> wrote: >> >>> Cura removed AMF support in 2016, at the same time that they added 3MF >>> support. >>> Various reasons were given for removing AMF support: >>> * nobody uses it >>> * the standard contradicts itself >>> * it is not an open standard (ie, devs need to pay money for a copy of >>> the standard, no sharing) >>> >>> >>> On 30 August 2018 at 10:31, Marius Kintel <marius@kintel.net> wrote: >>> >>>> It's entirely possible that we're ignoring a build error for the >>>> snapshot as well; we don't have an automated test pipeline set up for >>>> Windows as we do on the other platforms. >>>> >>>> I'd wager that virtually nobody uses AMF at all - that standard doesn't >>>> seem to be going anywhere : / >>>> >>>> -Marius >>>> >>>> On Thu, Aug 30, 2018 at 10:22 AM, nop head <nop.head@gmail.com> wrote: >>>> >>>>> It does nothing silently. Under MSYS2 I think it is a build problem >>>>> because qmake cant find libzip but I tested it with the Windows snapshot >>>>> and that doesn't work either. >>>>> I will look into it. >>>>> >>>>> So does nobody use AMF and Windows? >>>>> >>>>> Package libzip was not found in the pkg-config search path. >>>>> Perhaps you should add the directory containing `libzip.pc' >>>>> to the PKG_CONFIG_PATH environment variable >>>>> >>>>> >>>>> On 30 August 2018 at 14:21, Marius Kintel <marius@kintel.net> wrote: >>>>> >>>>>> On Aug 30, 2018, at 8:42 AM, nop head <nop.head@gmail.com> wrote: >>>>>> > >>>>>> > All the test that import AMF fail for me on Windows. >>>>>> > >>>>>> > Is this supposed to be working or is there an open issue for it? >>>>>> >>>>>> To my knowledge it’s supposed to work, but it’s not a very widely >>>>>> used feature, so I’m not sure where/when this last worked. >>>>>> If you have any more context about how it fails, that may be >>>>>> revealing. >>>>>> >>>>>> -Marius >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> OpenSCAD mailing list >>>>>> Discuss@lists.openscad.org >>>>>> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >>>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> OpenSCAD mailing list >>>>> Discuss@lists.openscad.org >>>>> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >>>>> >>>>> >>>> >>>> _______________________________________________ >>>> OpenSCAD mailing list >>>> Discuss@lists.openscad.org >>>> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >>>> >>>> >>> >>> _______________________________________________ >>> OpenSCAD mailing list >>> Discuss@lists.openscad.org >>> http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >>> >>> >> >

On 08/31/2018 01:34 AM, nop head wrote: > On Windows fs:path uses \ instead of / so the paths don't match those > in the maps of functions. So no functions are called and and empty > polyset is returned. > Oh, so instead of path.string() it should be path.generic_string()? ciao, Torsten.

Yes I will change it to a string as it isn't a file system path, so using fs::path also makes the code a bit confusing. On 31 August 2018 at 01:12, Torsten Paul <Torsten.Paul@gmx.de> wrote: > On 08/31/2018 01:34 AM, nop head wrote: > >> On Windows fs:path uses \ instead of / so the paths don't match those >> in the maps of functions. So no functions are called and and empty >> polyset is returned. >> >> Oh, so instead of path.string() it should be path.generic_string()? > > ciao, > Torsten. > > > _______________________________________________ > OpenSCAD mailing list > Discuss@lists.openscad.org > http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >