discuss@lists.openscad.org

OpenSCAD general discussion Mailing-list

View all threads

example of seemingly simple model

MK
Marius Kintel
Sat, Mar 30, 2024 7:50 PM

On Mar 30, 2024, at 10:23, Rogier Wolff R.E.Wolff@BitWizard.nl wrote:

IMHO, "repairing" is always a bit fishy. The obvious repair may seem
obvious, but it is not guaranteed to have been the intent. In theory
it can be "wrong".

Right, so we should probably only warn if the import is truly broken and needs repair where we need to guess the author’s intent.
Significant working hiding here of course - don’t think this is something that will bubble up to the top anytime soon..

-Marius

> On Mar 30, 2024, at 10:23, Rogier Wolff <R.E.Wolff@BitWizard.nl> wrote: > > IMHO, "repairing" is always a bit fishy. The obvious repair may seem > obvious, but it is not guaranteed to have been the intent. In theory > it can be "wrong". > Right, so we should probably only warn if the import is truly broken and needs repair where we need to guess the author’s intent. Significant working hiding here of course - don’t think this is something that will bubble up to the top anytime soon.. -Marius
RW
Rogier Wolff
Sun, Mar 31, 2024 6:45 PM

On Sat, Mar 30, 2024 at 03:50:10PM -0400, Marius Kintel via Discuss wrote:

On Mar 30, 2024, at 10:23, Rogier Wolff R.E.Wolff@BitWizard.nl wrote:

IMHO, "repairing" is always a bit fishy. The obvious repair may seem
obvious, but it is not guaranteed to have been the intent. In theory
it can be "wrong".

Right, so we should probably only warn if the import is truly broken
and needs repair where we need to guess the author’s intent.

Significant working hiding here of course - don’t think this is
something that will bubble up to the top anytime soon..

Hi Marius,

I strongly propose that non-manifold items are tagged ASAP,
i.e. already cause some sort of "warning" the moment they are
generated/imported/constructed.

On the other hand, I can understand that for "backwards compatiblity"
you do not want to "break" Sanjeev's project where a "fixable problem"
might generate a warning that wasn't there before...

Would it be an idea to call it an "info message": "the imported STL is
not fully manifold, may cause problems later". Thus not triggering the
"stop on first warning" (pleasing Sanjeev and "backward
compatiblity"), but also creating some sort of feedback the moment
such a "possible problem" is introduced in a project (pleasing me! :-)
).

I'd think this might be a "best of both worlds" compromise.

Roger.

--
** R.E.Wolff@BitWizard.nl ** https://www.BitWizard.nl/ ** +31-15-2049110 **
**    Delftechpark 11 2628 XJ  Delft, The Netherlands.  KVK: 27239233    **
f equals m times a. When your f is steady, and your m is going down
your a is going up.  -- Chris Hadfield about flying up the space shuttle.

On Sat, Mar 30, 2024 at 03:50:10PM -0400, Marius Kintel via Discuss wrote: > > On Mar 30, 2024, at 10:23, Rogier Wolff <R.E.Wolff@BitWizard.nl> wrote: > > > > IMHO, "repairing" is always a bit fishy. The obvious repair may seem > > obvious, but it is not guaranteed to have been the intent. In theory > > it can be "wrong". > > > Right, so we should probably only warn if the import is truly broken > and needs repair where we need to guess the author’s intent. > Significant working hiding here of course - don’t think this is > something that will bubble up to the top anytime soon.. Hi Marius, I strongly propose that non-manifold items are tagged ASAP, i.e. already cause some sort of "warning" the moment they are generated/imported/constructed. On the other hand, I can understand that for "backwards compatiblity" you do not want to "break" Sanjeev's project where a "fixable problem" might generate a warning that wasn't there before... Would it be an idea to call it an "info message": "the imported STL is not fully manifold, may cause problems later". Thus not triggering the "stop on first warning" (pleasing Sanjeev and "backward compatiblity"), but also creating some sort of feedback the moment such a "possible problem" is introduced in a project (pleasing me! :-) ). I'd think this might be a "best of both worlds" compromise. Roger. -- ** R.E.Wolff@BitWizard.nl ** https://www.BitWizard.nl/ ** +31-15-2049110 ** ** Delftechpark 11 2628 XJ Delft, The Netherlands. KVK: 27239233 ** f equals m times a. When your f is steady, and your m is going down your a is going up. -- Chris Hadfield about flying up the space shuttle.
MK
Marius Kintel
Sun, Mar 31, 2024 8:58 PM

Rogier, yeah I like that idea.

On Mar 31, 2024, at 14:45, Rogier Wolff R.E.Wolff@bitwizard.nl wrote:

On Sat, Mar 30, 2024 at 03:50:10PM -0400, Marius Kintel via Discuss wrote:

On Mar 30, 2024, at 10:23, Rogier Wolff R.E.Wolff@BitWizard.nl wrote:

IMHO, "repairing" is always a bit fishy. The obvious repair may seem
obvious, but it is not guaranteed to have been the intent. In theory
it can be "wrong".

Right, so we should probably only warn if the import is truly broken
and needs repair where we need to guess the author’s intent.

Significant working hiding here of course - don’t think this is
something that will bubble up to the top anytime soon..

Hi Marius,

I strongly propose that non-manifold items are tagged ASAP,
i.e. already cause some sort of "warning" the moment they are
generated/imported/constructed.

On the other hand, I can understand that for "backwards compatiblity"
you do not want to "break" Sanjeev's project where a "fixable problem"
might generate a warning that wasn't there before...

Would it be an idea to call it an "info message": "the imported STL is
not fully manifold, may cause problems later". Thus not triggering the
"stop on first warning" (pleasing Sanjeev and "backward
compatiblity"), but also creating some sort of feedback the moment
such a "possible problem" is introduced in a project (pleasing me! :-)
).

I'd think this might be a "best of both worlds" compromise.

Roger.

--
** R.E.Wolff@BitWizard.nl ** https://www.BitWizard.nl/ ** +31-15-2049110 **
**    Delftechpark 11 2628 XJ  Delft, The Netherlands.  KVK: 27239233    **
f equals m times a. When your f is steady, and your m is going down
your a is going up.  -- Chris Hadfield about flying up the space shuttle.

Rogier, yeah I like that idea. > On Mar 31, 2024, at 14:45, Rogier Wolff <R.E.Wolff@bitwizard.nl> wrote: > > On Sat, Mar 30, 2024 at 03:50:10PM -0400, Marius Kintel via Discuss wrote: >>>> On Mar 30, 2024, at 10:23, Rogier Wolff <R.E.Wolff@BitWizard.nl> wrote: >>> >>> IMHO, "repairing" is always a bit fishy. The obvious repair may seem >>> obvious, but it is not guaranteed to have been the intent. In theory >>> it can be "wrong". >>> > >> Right, so we should probably only warn if the import is truly broken >> and needs repair where we need to guess the author’s intent. > >> Significant working hiding here of course - don’t think this is >> something that will bubble up to the top anytime soon.. > > Hi Marius, > > I strongly propose that non-manifold items are tagged ASAP, > i.e. already cause some sort of "warning" the moment they are > generated/imported/constructed. > > On the other hand, I can understand that for "backwards compatiblity" > you do not want to "break" Sanjeev's project where a "fixable problem" > might generate a warning that wasn't there before... > > Would it be an idea to call it an "info message": "the imported STL is > not fully manifold, may cause problems later". Thus not triggering the > "stop on first warning" (pleasing Sanjeev and "backward > compatiblity"), but also creating some sort of feedback the moment > such a "possible problem" is introduced in a project (pleasing me! :-) > ). > > I'd think this might be a "best of both worlds" compromise. > > Roger. > > -- > ** R.E.Wolff@BitWizard.nl ** https://www.BitWizard.nl/ ** +31-15-2049110 ** > ** Delftechpark 11 2628 XJ Delft, The Netherlands. KVK: 27239233 ** > f equals m times a. When your f is steady, and your m is going down > your a is going up. -- Chris Hadfield about flying up the space shuttle.