discuss@lists.openscad.org

OpenSCAD general discussion Mailing-list

View all threads

New Release of OpenSCAD, soon - please test

TP
Torsten Paul
Tue, Feb 26, 2019 9:58 PM

On 26.02.19 22:49, WLarmon wrote:

nophead wrote

The official way to hide variables from the customiser is this:

/* [Hidden] */

Anything after is hidden.

With all due respect, this does not work.  I just double checked and I have
a bunch of variables visible in the Customizer after using

/* [hidden] */

h != H

It currently only works with upper case H, not sure what
happens on Thingiverse in that case.

ciao,
Torsten.

On 26.02.19 22:49, WLarmon wrote: > nophead wrote >> The official way to hide variables from the customiser is this: >> >> /* [Hidden] */ >> >> Anything after is hidden. > > With all due respect, this does not work. I just double checked and I have > a bunch of variables visible in the Customizer after using > > /* [hidden] */ > h != H It currently only works with upper case H, not sure what happens on Thingiverse in that case. ciao, Torsten.
TP
Torsten Paul
Tue, Feb 26, 2019 10:09 PM

On 26.02.19 22:57, WLarmon wrote:

/* [Hidden] */

doesn't work either.

It does for me, so please share the full code (well, trimmed
as much as possible) and the first couple of lines from
the Help->Library Info window.

ciao,
Torsten.

On 26.02.19 22:57, WLarmon wrote: > /* [Hidden] */ > > doesn't work either. It does for me, so please share the full code (well, trimmed as much as possible) and the first couple of lines from the Help->Library Info window. ciao, Torsten.
NH
nop head
Tue, Feb 26, 2019 10:11 PM

Yes works for me too. I cut and pasted from a working project.

On Tue, 26 Feb 2019 at 22:10, Torsten Paul Torsten.Paul@gmx.de wrote:

On 26.02.19 22:57, WLarmon wrote:

/* [Hidden] */

doesn't work either.

It does for me, so please share the full code (well, trimmed
as much as possible) and the first couple of lines from
the Help->Library Info window.

ciao,
Torsten.


OpenSCAD mailing list
Discuss@lists.openscad.org
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

Yes works for me too. I cut and pasted from a working project. On Tue, 26 Feb 2019 at 22:10, Torsten Paul <Torsten.Paul@gmx.de> wrote: > On 26.02.19 22:57, WLarmon wrote: > > /* [Hidden] */ > > > > doesn't work either. > > It does for me, so please share the full code (well, trimmed > as much as possible) and the first couple of lines from > the Help->Library Info window. > > ciao, > Torsten. > > > _______________________________________________ > OpenSCAD mailing list > Discuss@lists.openscad.org > http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org >
W
WLarmon
Tue, Feb 26, 2019 11:13 PM

nophead wrote

Yes works for me too. I cut and pasted from a working project.

On Tue, 26 Feb 2019 at 22:10, Torsten Paul <

Torsten.Paul@

> wrote:

On 26.02.19 22:57, WLarmon wrote:

/* [Hidden] */

doesn't work either.

It does for me, so please share the full code (well, trimmed
as much as possible) and the first couple of lines from
the Help->Library Info window.

ciao,
Torsten.

A section of the code

// Extrude springclamp_height on the handle?
label_springclamp = "true"; // [true,false]

/* [Hidden] */

// This stops variables from showing up in the Customizer
// (Actually any module definition stops them)
//module hidden() { }

/* {Film size options} */
// What is the slide format?  (Anything other than "film6x6", exactly, means
35mm or 110 (Instamatic).)
// We support both slides and negatives.  "film6x6 is 6x6cm slides or 120
film negative
// Not film6x6 could be either 35mm slides or negatives, or 110 (Instamatic)
negative.
//120 film/mounted 6x6cm slides or 35mm/110 negatives
//film = "film35"; // [film6x6:120 film or mounted 6x6cm slides,film35:35mm
(or 110) slides or negatives]
// outsideoffronttube must not be "true" if you use film6x6 and fronttube;
// (outsideoffronttube was designed for the edge case of making a short
front tube that fits on the outside
// of a real Xtend-a-Slide.
//
// Well and for making PVC end brackets.  So it isn't such an edge case
after all.  Sorry for the cross-confusion
// The PVC code is only for 35mm and does does not support film6x6x (120
film)

//is110 = "false"; // [true:Is 110 film? And 'film' must be 35mm.,false:not
110 (i.e. 35mm)]

film = (Film_size == "film6x6") ? "film6x6" : "film35" ;

Help -> Library info

OpenSCAD Version: 2019.01-RC2 (git 35858ead)
System information: Windows(TM) 10.0 SP 0.0 NTW 1 MSDN 724833 8 CPUs 15.85
GB RAM
User Agent: OpenSCAD/2019.01-RC2 (git 35858ead) (Windows(TM) 10.0 SP 0.0 NTW
1 MSDN 724833)
Compiler: GCC "7.3.0" 64bit

My code is 50+ pages long so you probably don't want me to paste it in its
entirety

The full code is at

http://www.frogymandias.org/3-d/index.html
http://www.frogymandias.org/3-d/index.html

--
Sent from: http://forum.openscad.org/

nophead wrote > Yes works for me too. I cut and pasted from a working project. > > On Tue, 26 Feb 2019 at 22:10, Torsten Paul &lt; > Torsten.Paul@ > &gt; wrote: > >> On 26.02.19 22:57, WLarmon wrote: >> > /* [Hidden] */ >> > >> > doesn't work either. >> >> It does for me, so please share the full code (well, trimmed >> as much as possible) and the first couple of lines from >> the Help->Library Info window. >> >> ciao, >> Torsten. A section of the code // Extrude springclamp_height on the handle? label_springclamp = "true"; // [true,false] /* [Hidden] */ // *This* stops variables from showing up in the Customizer // (Actually any module definition stops them) //module hidden() { } /* {Film size options} */ // What is the slide format? (Anything other than "film6x6", exactly, means 35mm or 110 (Instamatic).) // We support both slides and negatives. "film6x6 is 6x6cm slides or 120 film negative // Not film6x6 could be either 35mm slides or negatives, or 110 (Instamatic) negative. //120 film/mounted 6x6cm slides or 35mm/110 negatives //film = "film35"; // [film6x6:120 film or mounted 6x6cm slides,film35:35mm (or 110) slides or negatives] // outsideoffronttube must not be "true" if you use film6x6 and fronttube; // (outsideoffronttube was designed for the edge case of making a short front tube that fits on the outside // of a real Xtend-a-Slide. // // Well and for making PVC end brackets. So it isn't such an edge case after all. Sorry for the cross-confusion // The PVC code is only for 35mm and does does *not* support film6x6x (120 film) //is110 = "false"; // [true:Is 110 film? And 'film' must be 35mm.,false:not 110 (i.e. 35mm)] film = (Film_size == "film6x6") ? "film6x6" : "film35" ; Help -> Library info OpenSCAD Version: 2019.01-RC2 (git 35858ead) System information: Windows(TM) 10.0 SP 0.0 NTW 1 MSDN 724833 8 CPUs 15.85 GB RAM User Agent: OpenSCAD/2019.01-RC2 (git 35858ead) (Windows(TM) 10.0 SP 0.0 NTW 1 MSDN 724833) Compiler: GCC "7.3.0" 64bit My code is 50+ pages long so you probably don't want me to paste it in its entirety The full code is at http://www.frogymandias.org/3-d/index.html <http://www.frogymandias.org/3-d/index.html> -- Sent from: http://forum.openscad.org/
TP
Torsten Paul
Wed, Feb 27, 2019 12:08 AM

The /* [Hidden] */ is just a group marker, it does not
100% stop detection after it. It's the

/* {Film size options} */

comment which resets things even though it's not a real
group definition. I'd see that as bug right now, but we
probably want to check how Thingiverse behaves.

The empty module is a hard stop for the customizer
parameter detection, so regardless of what's coming
after it, it's ignored.

ciao,
Torsten.

The /* [Hidden] */ is just a group marker, it does not 100% stop detection after it. It's the /* {Film size options} */ comment which resets things even though it's not a real group definition. I'd see that as bug right now, but we probably want to check how Thingiverse behaves. The empty module is a hard stop for the customizer parameter detection, so regardless of what's coming after it, it's ignored. ciao, Torsten.
W
WLarmon
Wed, Feb 27, 2019 2:04 AM

tp3 wrote

The /* [Hidden] */ is just a group marker, it does not
100% stop detection after it. It's the

/* {Film size options} */

comment which resets things even though it's not a real
group definition. I'd see that as bug right now, but we
probably want to check how Thingiverse behaves.

The curly braces are placeholders from when I was trying to see what was
going on with

/* [Hidden] */

I was toggling them from curly braces to square braces.

My code is legacy code.  I've been working on the same project for several
years.  It really has four or five different projects in it.  But at this
point (50 + pages) it is too difficult to extract the most recent project
without breaking something.  Right now I test for everything that is exposed
in the Customizer and ignore the rest.  Shrug.

The empty module is a hard stop for the customizer
parameter detection, so regardless of what's coming
after it, it's ignored.

I consider the [Hidden] thing to be a minor issue.  All the complicated
parts of the Customizer and the new warning syntax errors seem to work well.

I hope my initial posts aren't coming off as confrontational.  I like
OpenSCAD a lot.

--
Sent from: http://forum.openscad.org/

tp3 wrote > The /* [Hidden] */ is just a group marker, it does not > 100% stop detection after it. It's the > > /* {Film size options} */ > > comment which resets things even though it's not a real > group definition. I'd see that as bug right now, but we > probably want to check how Thingiverse behaves. The curly braces are placeholders from when I was trying to see what was going on with /* [Hidden] */ I was toggling them from curly braces to square braces. My code is legacy code. I've been working on the same project for several years. It really has four or five different projects in it. But at this point (50 + pages) it is too difficult to extract the most recent project without breaking something. Right now I test for everything that is exposed in the Customizer and ignore the rest. Shrug. > The empty module is a hard stop for the customizer > parameter detection, so regardless of what's coming > after it, it's ignored. I consider the [Hidden] thing to be a minor issue. All the complicated parts of the Customizer and the new warning syntax errors seem to work well. I hope my initial posts aren't coming off as confrontational. I like OpenSCAD a lot. -- Sent from: http://forum.openscad.org/
SH
Stephan Hennig
Fri, Mar 1, 2019 8:19 PM

Am 24.02.2019 um 23:41 schrieb MichaelAtOz:

Please report any issue here, or on GitHub if you're sure it's a bug and you
have access.

[...]

Also note that there is now /significant syntax checking/ with Warning
Messages,

Regarding syntax checking, the following code outputs an odd waring

function somefunc(size) = 2 * size;
a = somefunc(size = 1, type = "foo");

$ openscad-nightly -o out.stl bug-1.scad
WARNING: variable type not specified as parameter, in file bug-1.scad, line 3
Current top level object is empty.

Formatting could perhaps be improved to more easily tell variable names
from the actual warning text.  Like wrapping the variable name in
quotes, angle brackets, something like that.

Best regards,
Stephan Hennig

$ openscad-nightly --version
OpenSCAD version 2019.02.28.nightly

Am 24.02.2019 um 23:41 schrieb MichaelAtOz: > Please report any issue here, or on GitHub if you're sure it's a bug and you > have access. > > [...] > > Also note that there is now /significant syntax checking/ with Warning > Messages, Regarding syntax checking, the following code outputs an odd waring function somefunc(size) = 2 * size; a = somefunc(size = 1, type = "foo"); > $ openscad-nightly -o out.stl bug-1.scad > WARNING: variable type not specified as parameter, in file bug-1.scad, line 3 > Current top level object is empty. Formatting could perhaps be improved to more easily tell variable names from the actual warning text. Like wrapping the variable name in quotes, angle brackets, something like that. Best regards, Stephan Hennig > $ openscad-nightly --version > OpenSCAD version 2019.02.28.nightly