discuss@lists.openscad.org

OpenSCAD general discussion Mailing-list

View all threads

render stats different

M
MichaelAtOz
Thu, Dec 18, 2014 11:08 PM

Is it a concern that the render stats are different from 2014.03 v's
2014.12.16

http://forum.openscad.org/file/n10617/stats.jpg

http://forum.openscad.org/file/n10617/stats2.jpg


Unless specifically shown otherwise above, my contribution is in the Public Domain; To the extent possible under law, I have waived all copyright and related or neighbouring rights to this work. This work is published globally via the internet. :) Inclusion of works of previous authors is not included in the above.

The TPP is no simple “trade agreement.”  Fight it! http://www.ourfairdeal.org/

View this message in context: http://forum.openscad.org/render-stats-different-tp10617.html
Sent from the OpenSCAD mailing list archive at Nabble.com.

Is it a concern that the render stats are different from 2014.03 v's 2014.12.16 <http://forum.openscad.org/file/n10617/stats.jpg> <http://forum.openscad.org/file/n10617/stats2.jpg> ----- Unless specifically shown otherwise above, my contribution is in the Public Domain; To the extent possible under law, I have waived all copyright and related or neighbouring rights to this work. This work is published globally via the internet. :) Inclusion of works of previous authors is not included in the above. The TPP is no simple “trade agreement.” Fight it! http://www.ourfairdeal.org/ -- View this message in context: http://forum.openscad.org/render-stats-different-tp10617.html Sent from the OpenSCAD mailing list archive at Nabble.com.
MK
Marius Kintel
Fri, Dec 19, 2014 6:39 AM

On Dec 18, 2014, at 18:08 PM, MichaelAtOz oz.at.michael@gmail.com wrote:

Is it a concern that the render stats are different from 2014.03 v's
2014.12.16

The reason for this is that we don’t currently quantize vertices before sending them to CGAL. We used to do this, and perhaps we should still be doing it.
It’s worth looking into.

The reason for this change is likely to be that we now use createNefPolyhedronFromPolySet() to feed data into CGAL:
https://github.com/openscad/openscad/blob/master/src/cgalutils.cc#L271

This could also be the remaining part of https://github.com/openscad/openscad/issues/691

-Marius

On Dec 18, 2014, at 18:08 PM, MichaelAtOz <oz.at.michael@gmail.com> wrote: > Is it a concern that the render stats are different from 2014.03 v's > 2014.12.16 > The reason for this is that we don’t currently quantize vertices before sending them to CGAL. We used to do this, and perhaps we should still be doing it. It’s worth looking into. The reason for this change is likely to be that we now use createNefPolyhedronFromPolySet() to feed data into CGAL: https://github.com/openscad/openscad/blob/master/src/cgalutils.cc#L271 This could also be the remaining part of https://github.com/openscad/openscad/issues/691 -Marius
MK
Marius Kintel
Sat, Dec 27, 2014 3:30 AM

Hi Michael,

See https://github.com/openscad/openscad/pull/1115
With that patch, the old vertex count is back.

-Marius

Hi Michael, See https://github.com/openscad/openscad/pull/1115 With that patch, the old vertex count is back. -Marius