As recommended I'm using modules as much as possible. I'd welcome any
general
critiques of this one (syntax, method, formatting, anything). But in
particular
why is it that my code seems to work OK, despite the two console errors
"Too
many unnamed arguments... What is wrong with those please?

// Creates a hollow partial cone

// Height = h
// Bottom diam = d1
// Top diam = d2
// center = true/false or 1/0; almost always use true
// $fn = typically 24 for control knob
// Thickness = t (same throughout)

module hollowCyl_Full(h, d1, d2, center, $fn, t) {

difference() {
// Larger diam, from which a difference is needed
cylinder(h, d1, d2, true, $fn); // ERROR?
<-----------------------------

// Remove smaller diam, but higher, protruding at both ends
cylinder(h+.01, d1-2t, d2-2t, true, $fn); // ERROR?
<-----------------
}
}

// EXAMPLE
hollowCyl_Full(9, 36, 28, true, 24, 1);

https://www.dropbox.com/s/jmfgtbbl48xrzc0/HollowConeError.jpg?raw=1

Terry

OpenSCAD mailing list
To unsubscribe send an email to discuss-leave@lists.openscad.org

As recommended I'm using modules as much as possible. I'd welcome any
general
critiques of this one (syntax, method, formatting, anything). But in
particular
why is it that my code seems to work OK, despite the two console errors
"Too
many unnamed arguments... What is wrong with those please?

// Creates a hollow partial cone

// Height = h
// Bottom diam = d1
// Top diam = d2
// center = true/false or 1/0; almost always use true
// $fn = typically 24 for control knob
// Thickness = t (same throughout)

module hollowCyl_Full(h, d1, d2, center, $fn, t) {

difference() {
// Larger diam, from which a difference is needed
cylinder(h, d1, d2, true, $fn); // ERROR?
<-----------------------------

// Remove smaller diam, but higher, protruding at both ends
cylinder(h+.01, d1-2t, d2-2t, true, $fn); // ERROR?
<-----------------
}
}

// EXAMPLE
hollowCyl_Full(9, 36, 28, true, 24, 1);

https://www.dropbox.com/s/jmfgtbbl48xrzc0/HollowConeError.jpg?raw=1

Terry

OpenSCAD mailing list
To unsubscribe send an email to discuss-leave@lists.openscad.org

I have made few changes and it works now in my system

// Creates a hollow partial cone

// Height = h
// Bottom diam = d1
// Top diam = d2
// center = true/false or 1/0; almost always use true
// $fn = typically 24 for control knob
// Thickness = t (same throughout)

module hollowCyl_Full(h, d1, d2, center, fn, t) {

difference() {
// Larger diam, from which a difference is needed
cylinder(h, d1, d2, center=center, $fn=fn); // ERROR?
<-----------------------------

// Remove smaller diam, but higher, protruding at both ends
cylinder(h+.01, d1-2t, d2-2t, center=center, $fn=fn); // ERROR?
<-----------------
}
}

// EXAMPLE
hollowCyl_Full(9, 36, 28, true, 24, 1);

On Sat, 19 Feb 2022 at 21:46, Terry terrypingm@gmail.com wrote:

As recommended I'm using modules as much as possible. I'd welcome any
general
critiques of this one (syntax, method, formatting, anything). But in
particular
why is it that my code seems to work OK, despite the two console errors
"Too
many unnamed arguments... What is wrong with those please?

// Creates a hollow partial cone

// Height = h
// Bottom diam = d1
// Top diam = d2
// center = true/false or 1/0; almost always use true
// $fn = typically 24 for control knob
// Thickness = t (same throughout)

module hollowCyl_Full(h, d1, d2, center, $fn, t) {

difference() {
// Larger diam, from which a difference is needed
cylinder(h, d1, d2, true, $fn); // ERROR?
<-----------------------------

// Remove smaller diam, but higher, protruding at both ends
cylinder(h+.01, d1-2t, d2-2t, true, $fn); // ERROR?
<-----------------
}
}

// EXAMPLE
hollowCyl_Full(9, 36, 28, true, 24, 1);

https://www.dropbox.com/s/jmfgtbbl48xrzc0/HollowConeError.jpg?raw=1

Terry

---

OpenSCAD mailing list
To unsubscribe send an email to discuss-leave@lists.openscad.org

the difference needs a translate down so you don't have colliding planes:

// Remove smaller diam, but higher, protruding at both ends
translate([0,0,-0.01])cylinder(h=h+.02, d1=d1-2t, d2=d2-2t, $fn);

On Sat, Feb 19, 2022 at 12:17 PM Terry terrypingm@gmail.com wrote:

Thanks both, appreciate the fast responses.

Sanjeev: Works fine and no errors!

Dave: No errors, but it did not give me the same result. Probably my
mistake.
Here's my revised code which I thought used your corrections?

// Creates a hollow partial cone

// Height = h
// Bottom diam = d1
// Top diam = d2
// center = true/false or 1/0; almost always use true
// $fn = typically 24 for control knob
// Thickness = t (same throughout)

module hollowCyl_Full(h, d1, d2, center, $fn, t) {

difference() {
// Larger diam, from which a difference is needed
cylinder(h=h, d1=d1, d2=d2, $fn);

// Remove smaller diam, but higher, protruding at both ends
cylinder(h=h+.01, d1=d1-2t, d2=d2-2t, $fn);
}
}

// EXAMPLE
hollowCyl_Full(9, 36, 28, true, 24, 1);

====================

On Sat, 19 Feb 2022 22:01:27 +0530, you wrote:

I have made few changes and it works now in my system

// Creates a hollow partial cone

// Height = h
// Bottom diam = d1
// Top diam = d2
// center = true/false or 1/0; almost always use true
// $fn = typically 24 for control knob
// Thickness = t (same throughout)

module hollowCyl_Full(h, d1, d2, center, fn, t) {

difference() {
// Larger diam, from which a difference is needed
cylinder(h, d1, d2, center=center, $fn=fn); // ERROR?
<-----------------------------

// Remove smaller diam, but higher, protruding at both ends
cylinder(h+.01, d1-2t, d2-2t, center=center, $fn=fn); // ERROR?
<-----------------
}
}

// EXAMPLE
hollowCyl_Full(9, 36, 28, true, 24, 1);

On Sat, 19 Feb 2022 at 21:46, Terry terrypingm@gmail.com wrote:

As recommended I'm using modules as much as possible. I'd welcome any
general
critiques of this one (syntax, method, formatting, anything). But in
particular
why is it that my code seems to work OK, despite the two console errors
"Too
many unnamed arguments... What is wrong with those please?

// Creates a hollow partial cone

// Height = h
// Bottom diam = d1
// Top diam = d2
// center = true/false or 1/0; almost always use true
// $fn = typically 24 for control knob
// Thickness = t (same throughout)

module hollowCyl_Full(h, d1, d2, center, $fn, t) {

difference() {
// Larger diam, from which a difference is needed
cylinder(h, d1, d2, true, $fn); // ERROR?
<-----------------------------

// Remove smaller diam, but higher, protruding at both ends
cylinder(h+.01, d1-2t, d2-2t, true, $fn); // ERROR?
<-----------------
}
}

// EXAMPLE
hollowCyl_Full(9, 36, 28, true, 24, 1);

https://www.dropbox.com/s/jmfgtbbl48xrzc0/HollowConeError.jpg?raw=1

Terry

---

OpenSCAD mailing list
To unsubscribe send an email to discuss-leave@lists.openscad.org

---

OpenSCAD mailing list
To unsubscribe send an email to discuss-leave@lists.openscad.org

As recommended I'm using modules as much as possible. I'd welcome any general
critiques of this one (syntax, method, formatting, anything). But in particular
why is it that my code seems to work OK, despite the two console errors "Too
many unnamed arguments... What is wrong with those please?

// Creates a hollow partial cone

// Height = h
// Bottom diam = d1
// Top diam = d2
// center = true/false or 1/0; almost always use true
// $fn = typically 24 for control knob
// Thickness = t (same throughout)

module hollowCyl_Full(h, d1, d2, center, $fn, t) {

difference() {
// Larger diam, from which a difference is needed
cylinder(h, d1, d2, true, $fn); // ERROR? <-----------------------------

// Remove smaller diam, but higher, protruding at both ends
cylinder(h+.01, d1-2t, d2-2t, true, $fn); // ERROR? <-----------------
}
}

// EXAMPLE
hollowCyl_Full(9, 36, 28, true, 24, 1);

https://www.dropbox.com/s/jmfgtbbl48xrzc0/HollowConeError.jpg?raw=1

Terry

I allowed for that with my h+0.01.

I think the problem arises because of your
h=h
and
h=h+.01

On Sat, Feb 19, 2022 at 06:40:43PM +0000, Terry wrote:

I allowed for that with my h+0.01.

No you didn't. You elevated the top surface of the subtracted cylinder
by 0.01, so that doesn't clash with the subtracted-from cylinder's top
surface. But both bottom surfaces are still at precisely 0.000.

I think the problem arises because of your
h=h
and
h=h+.01

You're thinking that does something funny because "h may be modified by
h=h+.01" ? That's not the case,
OpenScad allows variable-looking things to have the same name, but in
fact they are different variable-looking-things.

In
cylinder(h=h+.02, d1=d1-2t, d2=d2-2t, $fn);

The first "h" is "the cylinder parameter called h". and the second one
is the "local variable called h". Those are entirely different things
and could have WILDLY different values.

Nothing funny happens when you know what's going on. Feel free to do

pipe (dd, hh, t)
{
difference () {
cylinder (d=dd+2*t, h=hh, center=true);
cylinder (d=dd, h=hh+.2, center=true);
}
}

like I sometimes do, if you don't trust that stuff.

Roger. 

Terry

====================

On Sat, 19 Feb 2022 12:51:26 -0500, you wrote:

the difference needs a translate down so you don't have colliding planes:

// Remove smaller diam, but higher, protruding at both ends
translate([0,0,-0.01])cylinder(h=h+.02, d1=d1-2t, d2=d2-2t, $fn);

On Sat, Feb 19, 2022 at 12:17 PM Terry terrypingm@gmail.com wrote:

Thanks both, appreciate the fast responses.

Sanjeev: Works fine and no errors!

Dave: No errors, but it did not give me the same result. Probably my
mistake.
Here's my revised code which I thought used your corrections?

// Creates a hollow partial cone

// Height = h
// Bottom diam = d1
// Top diam = d2
// center = true/false or 1/0; almost always use true
// $fn = typically 24 for control knob
// Thickness = t (same throughout)

module hollowCyl_Full(h, d1, d2, center, $fn, t) {

difference() {
// Larger diam, from which a difference is needed
cylinder(h=h, d1=d1, d2=d2, $fn);

// Remove smaller diam, but higher, protruding at both ends
cylinder(h=h+.01, d1=d1-2t, d2=d2-2t, $fn);
}
}

// EXAMPLE
hollowCyl_Full(9, 36, 28, true, 24, 1);

====================

On Sat, 19 Feb 2022 22:01:27 +0530, you wrote:

I have made few changes and it works now in my system

// Creates a hollow partial cone

// Height = h
// Bottom diam = d1
// Top diam = d2
// center = true/false or 1/0; almost always use true
// $fn = typically 24 for control knob
// Thickness = t (same throughout)

module hollowCyl_Full(h, d1, d2, center, fn, t) {

difference() {
// Larger diam, from which a difference is needed
cylinder(h, d1, d2, center=center, $fn=fn); // ERROR?
<-----------------------------

// Remove smaller diam, but higher, protruding at both ends
cylinder(h+.01, d1-2t, d2-2t, center=center, $fn=fn); // ERROR?
<-----------------
}
}

// EXAMPLE
hollowCyl_Full(9, 36, 28, true, 24, 1);

On Sat, 19 Feb 2022 at 21:46, Terry terrypingm@gmail.com wrote:

As recommended I'm using modules as much as possible. I'd welcome any
general
critiques of this one (syntax, method, formatting, anything). But in
particular
why is it that my code seems to work OK, despite the two console errors
"Too
many unnamed arguments... What is wrong with those please?

// Creates a hollow partial cone

// Height = h
// Bottom diam = d1
// Top diam = d2
// center = true/false or 1/0; almost always use true
// $fn = typically 24 for control knob
// Thickness = t (same throughout)

module hollowCyl_Full(h, d1, d2, center, $fn, t) {

difference() {
// Larger diam, from which a difference is needed
cylinder(h, d1, d2, true, $fn); // ERROR?
<-----------------------------

// Remove smaller diam, but higher, protruding at both ends
cylinder(h+.01, d1-2t, d2-2t, true, $fn); // ERROR?
<-----------------
}
}

// EXAMPLE
hollowCyl_Full(9, 36, 28, true, 24, 1);

https://www.dropbox.com/s/jmfgtbbl48xrzc0/HollowConeError.jpg?raw=1

Terry

---

OpenSCAD mailing list
To unsubscribe send an email to discuss-leave@lists.openscad.org

---

OpenSCAD mailing list
To unsubscribe send an email to discuss-leave@lists.openscad.org

---

OpenSCAD mailing list
To unsubscribe send an email to discuss-leave@lists.openscad.org

the difference needs a translate down so you don't have colliding planes:

    cylinder(h=h, d1=d1, d2=d2, $fn);