discuss@lists.openscad.org

OpenSCAD general discussion Mailing-list

View all threads

Can I get some code review up in here?

R
runsun
Tue, Apr 14, 2015 4:25 AM

Thx. Looking at fonts.scad and example023.scad, I can see why search() is
needed :)

clothbot wrote

Yeah, when I wrote search() the two primary use modes I focused on were
basic character(s)-in-string and searching for matches in list-of-lists.

Have a look at my old example23.scad (see
https://github.com/openscad/openscad/blob/master/examples/Old/example023.scad
<https://github.com/openscad/openscad/blob/master/examples/Old/example023.scad>)
and how I structured MCAD/fonts.scad (see
https://github.com/openscad/MCAD/blob/master/fonts.scad
<https://github.com/openscad/MCAD/blob/master/fonts.scad>)  to get
some insight into how I wanted to (ab)use it.

Andrew.


$  Runsun Pan, PhD

$ -- OpenScad_DocTest: doc and unit test ( Github , Thingiverse  )

$ -- hash parameter model: here , here

$ -- Linux Mint 17.1 Rebecca x64  + OpenSCAD 2015.03.15/2015.04.01.nightly

--
View this message in context: http://forum.openscad.org/Can-I-get-some-code-review-up-in-here-tp12341p12363.html
Sent from the OpenSCAD mailing list archive at Nabble.com.

Thx. Looking at fonts.scad and example023.scad, I can see why search() is needed :) clothbot wrote > Yeah, when I wrote search() the two primary use modes I focused on were > basic character(s)-in-string and searching for matches in list-of-lists. > > Have a look at my old example23.scad (see > https://github.com/openscad/openscad/blob/master/examples/Old/example023.scad > &lt;https://github.com/openscad/openscad/blob/master/examples/Old/example023.scad&gt;) > and how I structured MCAD/fonts.scad (see > https://github.com/openscad/MCAD/blob/master/fonts.scad > &lt;https://github.com/openscad/MCAD/blob/master/fonts.scad&gt;) to get > some insight into how I wanted to (ab)use it. > > Andrew. ----- $ Runsun Pan, PhD $ -- OpenScad_DocTest: doc and unit test ( Github , Thingiverse ) $ -- hash parameter model: here , here $ -- Linux Mint 17.1 Rebecca x64 + OpenSCAD 2015.03.15/2015.04.01.nightly -- View this message in context: http://forum.openscad.org/Can-I-get-some-code-review-up-in-here-tp12341p12363.html Sent from the OpenSCAD mailing list archive at Nabble.com.
M
MichaelAtOz
Tue, Apr 14, 2015 5:28 AM

Also see my  GFan Lib Thing http://www.thingiverse.com/thing:111187  for
further examples.


Unless specifically shown otherwise above, my contribution is in the Public Domain; To the extent possible under law, I have waived all copyright and related or neighbouring rights to this work. This work is published globally via the internet. :) Inclusion of works of previous authors is not included in the above.

The TPP is no simple “trade agreement.”  Fight it! http://www.ourfairdeal.org/

View this message in context: http://forum.openscad.org/Can-I-get-some-code-review-up-in-here-tp12341p12365.html
Sent from the OpenSCAD mailing list archive at Nabble.com.

Also see my GFan Lib Thing <http://www.thingiverse.com/thing:111187> for further examples. ----- Unless specifically shown otherwise above, my contribution is in the Public Domain; To the extent possible under law, I have waived all copyright and related or neighbouring rights to this work. This work is published globally via the internet. :) Inclusion of works of previous authors is not included in the above. The TPP is no simple “trade agreement.” Fight it! http://www.ourfairdeal.org/ -- View this message in context: http://forum.openscad.org/Can-I-get-some-code-review-up-in-here-tp12341p12365.html Sent from the OpenSCAD mailing list archive at Nabble.com.
R
runsun
Tue, Apr 14, 2015 6:53 PM

Cool. Very similar to my approach. I suppose your Fan Lib (matching integers
using lookup) will run faster than my hash model (matching string via
recursive scanning).

MichaelAtOz wrote

Also see my
Fan Lib Thing http://www.thingiverse.com/thing:111187
for further examples.


$  Runsun Pan, PhD

$ -- OpenScad_DocTest: doc and unit test ( Github , Thingiverse  )

$ -- hash parameter model: here , here

$ -- Linux Mint 17.1 Rebecca x64  + OpenSCAD 2015.03.15/2015.04.01.nightly

--
View this message in context: http://forum.openscad.org/Can-I-get-some-code-review-up-in-here-tp12341p12370.html
Sent from the OpenSCAD mailing list archive at Nabble.com.

Cool. Very similar to my approach. I suppose your Fan Lib (matching integers using lookup) will run faster than my hash model (matching string via recursive scanning). MichaelAtOz wrote > Also see my > Fan Lib Thing <http://www.thingiverse.com/thing:111187> > for further examples. ----- $ Runsun Pan, PhD $ -- OpenScad_DocTest: doc and unit test ( Github , Thingiverse ) $ -- hash parameter model: here , here $ -- Linux Mint 17.1 Rebecca x64 + OpenSCAD 2015.03.15/2015.04.01.nightly -- View this message in context: http://forum.openscad.org/Can-I-get-some-code-review-up-in-here-tp12341p12370.html Sent from the OpenSCAD mailing list archive at Nabble.com.
AP
Andrew Plumb
Thu, Apr 16, 2015 10:08 AM

Marius has pulled my fixes to search and my updates to example023.scad (removing the deprecated use of assign()).  Anything built from today (April 16th) onward should be good to go!

Andrew.

On Apr 14, 2015, at 12:25 AM, runsun runsun@gmail.com wrote:

Thx. Looking at fonts.scad and example023.scad, I can see why search() is
needed :)

clothbot wrote

Yeah, when I wrote search() the two primary use modes I focused on were
basic character(s)-in-string and searching for matches in list-of-lists.

Have a look at my old example23.scad (see
https://github.com/openscad/openscad/blob/master/examples/Old/example023.scad
<https://github.com/openscad/openscad/blob/master/examples/Old/example023.scad>)
and how I structured MCAD/fonts.scad (see
https://github.com/openscad/MCAD/blob/master/fonts.scad
<https://github.com/openscad/MCAD/blob/master/fonts.scad>)  to get
some insight into how I wanted to (ab)use it.

Andrew.


$  Runsun Pan, PhD

$ -- OpenScad_DocTest: doc and unit test ( Github , Thingiverse  )

$ -- hash parameter model: here , here

$ -- Linux Mint 17.1 Rebecca x64  + OpenSCAD 2015.03.15/2015.04.01.nightly

--
View this message in context: http://forum.openscad.org/Can-I-get-some-code-review-up-in-here-tp12341p12363.html
Sent from the OpenSCAD mailing list archive at Nabble.com.


OpenSCAD mailing list
Discuss@lists.openscad.org
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

Marius has pulled my fixes to search and my updates to example023.scad (removing the deprecated use of assign()). Anything built from today (April 16th) onward should be good to go! Andrew. > On Apr 14, 2015, at 12:25 AM, runsun <runsun@gmail.com> wrote: > > Thx. Looking at fonts.scad and example023.scad, I can see why search() is > needed :) > > > clothbot wrote >> Yeah, when I wrote search() the two primary use modes I focused on were >> basic character(s)-in-string and searching for matches in list-of-lists. >> >> Have a look at my old example23.scad (see >> https://github.com/openscad/openscad/blob/master/examples/Old/example023.scad >> &lt;https://github.com/openscad/openscad/blob/master/examples/Old/example023.scad&gt;) >> and how I structured MCAD/fonts.scad (see >> https://github.com/openscad/MCAD/blob/master/fonts.scad >> &lt;https://github.com/openscad/MCAD/blob/master/fonts.scad&gt;) to get >> some insight into how I wanted to (ab)use it. >> >> Andrew. > > > > > > ----- > > $ Runsun Pan, PhD > > $ -- OpenScad_DocTest: doc and unit test ( Github , Thingiverse ) > > $ -- hash parameter model: here , here > > $ -- Linux Mint 17.1 Rebecca x64 + OpenSCAD 2015.03.15/2015.04.01.nightly > > > > > -- > View this message in context: http://forum.openscad.org/Can-I-get-some-code-review-up-in-here-tp12341p12363.html > Sent from the OpenSCAD mailing list archive at Nabble.com. > > _______________________________________________ > OpenSCAD mailing list > Discuss@lists.openscad.org > http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
YS
Yvette S. Hirth, CCP, CDP
Fri, Apr 17, 2015 2:50 PM

hi all,

hey, does anyone know where a "ramp" symbol could be found?

the "ramp" symbol is whatcha see on euro volume controls, you know, it's
a "triangle" that's thin on the left, the top slopes up and to the
right, and it's thick on the right.

it's for a dimmer, and i'm trying to be "language independent".  so i'm
trying to write() the symbol on the dimmer cover.

can we write() bitmaps?

thanks!
yvette

hi all, hey, does anyone know where a "ramp" symbol could be found? the "ramp" symbol is whatcha see on euro volume controls, you know, it's a "triangle" that's thin on the left, the top slopes up and to the right, and it's thick on the right. it's for a dimmer, and i'm trying to be "language independent". so i'm trying to write() the symbol on the dimmer cover. can we write() bitmaps? thanks! yvette
ER
Ezra Reynolds
Fri, Apr 17, 2015 4:24 PM

polygon (points=[[0,0],[10,0],[10,3]]);

Sent from my iPhone

On Apr 17, 2015, at 10:50 AM, "Yvette S. Hirth, CCP, CDP" yvette@dbtgroup.com wrote:

hi all,

hey, does anyone know where a "ramp" symbol could be found?

the "ramp" symbol is whatcha see on euro volume controls, you know, it's a "triangle" that's thin on the left, the top slopes up and to the right, and it's thick on the right.

it's for a dimmer, and i'm trying to be "language independent".  so i'm trying to write() the symbol on the dimmer cover.

can we write() bitmaps?

thanks!
yvette


OpenSCAD mailing list
Discuss@lists.openscad.org
http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org

polygon (points=[[0,0],[10,0],[10,3]]); Sent from my iPhone > On Apr 17, 2015, at 10:50 AM, "Yvette S. Hirth, CCP, CDP" <yvette@dbtgroup.com> wrote: > > hi all, > > hey, does anyone know where a "ramp" symbol could be found? > > the "ramp" symbol is whatcha see on euro volume controls, you know, it's a "triangle" that's thin on the left, the top slopes up and to the right, and it's thick on the right. > > it's for a dimmer, and i'm trying to be "language independent". so i'm trying to write() the symbol on the dimmer cover. > > can we write() bitmaps? > > thanks! > yvette > > _______________________________________________ > OpenSCAD mailing list > Discuss@lists.openscad.org > http://lists.openscad.org/mailman/listinfo/discuss_lists.openscad.org
YS
Yvette S. Hirth, CCP, CDP
Fri, Apr 17, 2015 4:53 PM

On 04/17/2015 09:24 AM, Ezra Reynolds wrote:

polygon (points=[[0,0],[10,0],[10,3]]);

thanks!
yvette

On 04/17/2015 09:24 AM, Ezra Reynolds wrote: > polygon (points=[[0,0],[10,0],[10,3]]); thanks! yvette